Fix feedback from Sitemapbundle
Description
Deployment actions
Technical tasks
-See issue \/
Activity
Marijn Otte June 20, 2018 at 2:19 PM
I already deployed this to be able to test this and other issues
Jan Sanne Mulder June 19, 2018 at 8:50 AM(edited)
Articles with a future publication data should not be in the sitemap (https://integrated-latest.e-activesites.nl/admin/content/0180970e4497303f88e3a48c19773fd2)
The "old" sitemap bundle also didn't do that which means its a new feature and falls out site the scope of this issue.
Marijn Otte June 18, 2018 at 8:08 PM(edited)
Error introduced "Type error: Argument 4 passed to Integrated\Bundle\CommentBundle\EventListener\CommentFormFieldsSubscriber::__construct() must be an instance of Symfony\Bundle\FrameworkBundle\Routing\Router, instance of Integrated\Common\Routing\Router given, called in /home/integrated-latest/var/cache/dev/ContainerWzqxxt9/getIntegratedContent_Form_ContentFormTypeService.php on line 16" https://integrated-latest.e-activesites.nl/app_dev.php/admin/content/0d1c84a3ae1a36f99697e4ed48f91680
1.000 urls for news sitemap is OK, but please increase the normal sitemap to 50.000 urls (which is the maximum allowed). Sites with for example 70.000 articles are common, and 70 sitemap xml's are not easy to maintain in Google Search Console.
Articles with a future publication data should not be in the sitemap (https://integrated-latest.e-activesites.nl/admin/content/0180970e4497303f88e3a48c19773fd2)
Note: the new router does not support modified URL's for content types (like https://integrated-latest.e-activesites.nl/app_dev.php/admin/content-type-page/85495afbf17b347da10d0f981654c467/edit), but the old SitemapBundle didn't do that as well so we can fix that in
Jeroen van Leeuwen June 14, 2018 at 4:31 AM
looks good, now its his turn.
Could you next time provide two PR's: one of the code clean up and one with the actual changes. Thanks!
API June 7, 2018 at 1:32 PM
.Notificatie urenschatting gestuurd naar Integrated Marijn (marijn@e-active.nl)
Details
Details
Assignee
Client
e-Active team
Original estimate
Sprint
Fix versions
Parent
OTM informatie
Open OTM informatie
OTM informatie
Fix the feedback for issue https://bitbucket.org/eactive/integrated/pull-requests/50/integrated-1341-added-sitemap-bundle/diff#chg-src/Bundle/SitemapBundle/Resources/views/default/robots.txt.twig
1. Make a service of the Controller
2. Paginate the sitemaps since there are large amount of content possible: https://support.google.com/webmasters/answer/183668
https://support.google.com/webmasters/answer/75712
3. Fix the URL generation