When a format is selected, it's not highlighted.

Description

Steps

  • Select an image

  • Choose a format (like image align left)

  • The drop down closes, and when clicking 'formats' again, the chosen format is not higlighted.

Result

Analysis

  • Upgrading TinyMCE to the newest version does not help

  • It works in Integrated 0.4

  • Assumption: some javascripts prevents the editor from showing this information, maybe the "Add comment" script

Requirement

  • Find out if it works without the comment script

  • If yo: make a fix in the comment script

  • If not: try to find the affecting script

Technical tasks

None

Deployment actions

None

Activity

Show:
Johan Liefers
May 22, 2017, 12:47 PM

I can't figure out the exact problem. Spent a lot of time changing stuff, but I can't pinpoint the exact problem.
Sometimes it appears as if it works better when you remove these lines:

Sometimes it looks as if it is caused by the css code, I also think updating tinyMce might help a litte, but I don't know how to really fix this.

Johan Liefers
May 22, 2017, 12:49 PM

It doesn't seem te be caused by the comment bundle

Marijn Otte
May 24, 2017, 2:57 PM

I found the problem:

This line is defined in vendor/integrated/content-bundle/Resources/public/sass/components/_tinymce.scss

I think it can be removed, because I don't see a difference when I turn it off (except that the format highlight is back)

Johan Liefers
May 26, 2017, 7:16 AM

I think I misunderstood you, I thought the problem was that the image gets deselected when you change the style. But this indeed seems to fix the issue with the selected style.

Marijn Otte
May 29, 2017, 12:26 PM

this is also fixed now

Assignee

Unassigned

External issue ID

None

Client

Integrated Marijn

Min. hours

None

Dev hour estimate

None

Epic Link

Fix versions

Configure