You write the PR looks good, but the PR itself has the status 'Declined'. Can you say what the real status should be?
I don't know how, but it is already merged. So this one can be tested. When uploading and deletion works the test is OK
test NOK:
Test at environment with 0.4 & 0.5 gives this error when clicking 'create' at uploaden file or media type:
Fatal error: Class Integrated\Bundle\StorageBundle\Form\Upload\StorageIntentUpload contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Integrated\Common\Content\Document\Storage\Embedded\StorageInterface:ostWrite) in /home/<clientname>/vendor/integrated/storage-bundle/Form/Upload/StorageIntentUpload.php on line 98
Fatal error: Uncaught exception 'Symfony\Component\Debug\Exception\FatalErrorException' with message 'Error: Class Integrated\Bundle\StorageBundle\Form\Upload\StorageIntentUpload contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Integrated\Common\Content\Document\Storage\Embedded\StorageInterface:ostWrite)' in /home/<clientname>/vendor/integrated/storage-bundle/Form/Upload/StorageIntentUpload.php:98 Stack trace: #0{main}
Next exception 'InvalidArgumentException' with message 'Unable to find file "@AppBundle/Resources/views/themes/default/base.html.twig".' in /home/<clientname>/app/bootstrap.php.cache:2515 Stack trace: #0 /home/<clientname>/app/cache/prod/classes.php(4362): Symfony\Component\HttpKernel\Kernel->locateResource('@AppBundle/Reso...', '/home/<clientname>...', true) #1 /home/<clientname>/vendor/integrated/storage-bundle/Locator/StorageLocator.php(62): Symfony\Component\HttpKernel\Config\FileLocator->locate('@App in /home/<clientname>/vendor/symfony/symfony/src/Symfony/Bundle/TwigBundle/Loader/FilesystemLoader.php on line 91
Test at another environment with 0.4 & 0.5 (other client):
_
The class 'Integrated\Bundle\StorageBundle\Form\Upload\StorageIntentUpload' was not found in the chain configured namespaces Integrated\Bundle\ContentBundle\Document, Integrated\Bundle\PageBundle\Document, Integrated\Bundle\BlockBundle\Document, <clientname>\Bundle\CompanyBundle\Document, <clientname>\Bundle\ExpertBundle\Document, <clientname>\Bundle\ProductBundle\Document, <clientname>\Bundle\ReviewBundle\Document, <clientname>\Bundle\ThemeBundle\Document, <clientname>\Bundle\BlockBundle\Document, <clientname>\Bundle\CommonBundle\Document, AppBundle\Document, Integrated\Bundle\MenuBundle\Document
_
Test at environment with 0.4:
:
Issue is tested, test NOK. This issue is pending in the list with errors now, should we do something with it now?
I added the blocking issue. We'll have to wait for a fix in that issue before this can be tested again.