Upgrade to Symfony 3.4

Description

Background

Integrated 0.8 will require Symfony 3.4

Requirements

  • On Symfony 2.8 and 3.4, run the two tools mentioned on https://knpuniversity.com/screencast/symfony3-upgrade/deprecation-fixing-tools. Fix all deprecated code.

  • On Symfony 2.8 and 3.4, run unit tests and Behat tests to find deprecated warnings. Fix all deprecated code.

  • Move Symfony version to 3.4

  • Set up the new directory structure for the skeleton

  • Run unit tests and Behat tests again. Fix all errors.

Technical tasks

None

Deployment actions

Integrated 0.8 ships with Symfony 3.4. Follow the upgrade guides from Symfony when upgrading your code from Symfony 2.8 to 3.4:

Other changes are:

  • The Integrated bundles are combined in one repository. Load integrated/integrated as composer package

  • The view directories within Integrated are now lowercase (following the Symfony best practices)

  • For mongodb_options in parameters.yml you might need to replace "db" with "authSource" to specify the authentication database

  • Uglyfyjs is not required any more, becuase of future Webpack migration

Activity

Show:
Jeroen van Leeuwen
February 8, 2018, 6:12 AM

this is correct, since SF 3.0 the _format parameter can not be used:
https://symfony.com/doc/2.8/routing.html#advanced-routing-example

I will fix this in this issue.

I will expand the current PR with this fix.

Jeroen van Leeuwen
February 8, 2018, 7:54 AM

(cc ) I have fixed the _format parameters (not only for the select2 relation component but for all the bundles).

Marijn Otte
February 8, 2018, 9:44 AM
Edited

We are making progress, but still some errors:

Adding a content item from a relation does not work:
Unable to find template "IntegratedContentBundle:Content:saved.iframe.html.twig" (looked into: /home/integrated-7latest/vendor/knplabs/knp-menu/src/Knp/Menu/Resources/views, /home/integrated-7latest/app/Resources/views, /home/integrated-7latest/vendor/symfony/symfony/src/Symfony/Bridge/Twig/Resources/views/Form).

http://integrated-7latest.e-activesites.nl/app_dev.php/admin/block:
Unable to find template "IntegratedBlockBundle:Form:form_div_filter.html.twig" (looked into: /home/integrated-7latest/vendor/knplabs/knp-menu/src/Knp/Menu/Resources/views, /home/integrated-7latest/app/Resources/views, /home/integrated-7latest/vendor/symfony/symfony/src/Symfony/Bridge/Twig/Resources/views/Form).

Assigning a user to content item does not work:

Unknown "sameas" test. Did you mean "same as"?
Exception Logs 1 Stack Trace
Twig_Error_Syntax
in vendor/integrated/thompson-theme-bundle/Resources/views/themes/thompson/menu/top.navigation.html.twig (line 5)
(different repo, if it takes time we can add another issue for this)

Jeroen van Leeuwen
February 8, 2018, 12:40 PM

two more PR's... They keep comming..

Jeroen van Leeuwen
February 8, 2018, 12:55 PM

issues are fixed (also the Thompson theme).

Assignee

Unassigned

Client

Integrated Marijn

Epic Link

Sprint

None

Fix versions

Configure