Dirty code: SolrType
The team came across some dirty code in SolrTypes.
Improve the dirty code, without change of functionalies
.Notificatie oplevering gestuurd naar Integrated Marijn (firstname.lastname@example.org)
.Notificatie preview gestuurd naar Integrated Marijn (email@example.com)
zou je deze PR van Integrated kunnen controleren?
Discussed in the Integrated meeting that this missing Solr types will be reverted
we will discuss it in the Integrated team, but this is my opinion:
The "Has images" is an essential Integrated feature. Almost every template has content block with images, so creating a search selection on it must be possible. For content management purposes it is also very useful to be able to filter your content on articles with / without images. Multiple clients are using this feature already in many search selections. Clients also requested more properties already, such as "Has video".
I think the relation_json type is useful to have in Integrated. As far as we know now, this is the best way to implement this and we don't want to invent the wheel for every client. And if I am correctly multiple installations are already using this.
Both types are subject for discussion about the implementation however.