Do not convert SVG logos

Description

Background

It is possible to add an SVG logo for a channel. However, when using it on the frontend the integrated_image function converts it to PNG, which is less in quality.

Requirements

  • integrated_image should return SVG for SVG input, do not convert SVG logos to PNG

  • all conversion functions (like resize) should be ignored, because they are not relevant for vector format

Technical info

  • In integrated\Bundles\ImageBundle\Resources\config\services.xml the svg format can be added. This allows uploading it.

  • In integrated\Bundles\ImageBundle\Twig\Extension\ImageExtension.php the webImage and image return an \Gregwar\ImageBundle\ImageHandler object, which doesn't support svg. It uses the \Gregwar\ImageBundle\Services\ImageHandling.php to create the object, but this service doesn't support svg either

Technical tasks

None

Deployment actions

None

Activity

Show:
Jeroen van Leeuwen
March 28, 2018, 10:38 AM

ga hier nu induiken!

Gerben Bosch
April 6, 2018, 7:42 AM

Yo, kun jij deze nog even op de planning zetten?

Jeroen van Leeuwen
April 6, 2018, 1:12 PM

ja ga ik nu ff bekijken

Jeroen van Leeuwen
April 10, 2018, 6:03 AM

bedankt voor de fixes. Ik heb nog 1 puntje mbt de service definitie. Zou je hier nog naar kunnen kijken?

API
April 11, 2018, 12:03 PM

.Notificatie oplevering gestuurd naar Integrated Marijn (marijn@e-active.nl)

Assignee

Unassigned

Client

Integrated Marijn

Epic Link

Sprint

None

Fix versions

Configure