Uploaded image for project: 'Integrated'
  1. INTEGRATED-1264

Add theme path global variable and use it to include base views in Thompson / default theme, using the template locator

    Details

    • Epic Link:
    • Story Points:
      3
    • Deployment actions:
      Hide

      DEPRECATED:

      • _theme global -> integrated_active_theme()
      Show
      DEPRECATED: _theme global -> integrated_active_theme()
    • Team:
      Team A
    • Sprint:
      Team A Sprint 51, Team A Sprint 42, Team A Sprint 52

      Description

      Background

      When a theme base view override is made from the Thompson / default or theme, the original base view is used in all content item templates. This should be done dynamic by getting the path from the template locator.

      Requirements

      Support including the base view of the current theme, instead of a hardcoded bundle.

      Development plan

      We would like to combine the namespaced twig paths with a "helper" that gives us the active path:

      {% extends integrated_active_theme("layout.html.twig") %}	
      

      In this case integrated_active_theme returns a namespaced path, for example:

      @ci_thompson/layout.html.twig

      Things that needs to be changed:
      1. Config.yml needs the namespaces, example:

      twig: 
          # ...
          paths: 
              '%kernel.project_dir%/vendor/acme/themes/ci_thompson': ci_thompson
              '%kernel.project_dir%/vendor/acme/themes/thompson': ci_thompson
              '%kernel.project_dir%/vendor/acme/themes/common': ci_thompson
      		
      		
              '%kernel.project_dir%/vendor/acme/themes/thompson': thompson
              '%kernel.project_dir%/vendor/acme/themes/common': thompson		
      

      2. Layout/block selector in Integrated needs to look at the namespaces and return the views that can be found.
      3. The themes needs to be changed (but this should also be done in the other solutions).
      4. The theme manager (perhaps the whole ThemeBundle) can be "deleted" with the recursive path "shizzle".

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              marijn Marijn Otte
              Product owner:
              Maartje Wessels-Wouda
              Client:
              Integrated Marijn
              Developer:
              Ger Jan van den Bosch (Inactive)
              Code reviewer:
              Jeroen van Leeuwen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                OTM